Cleanup: Remove the ai-logs flag.

[jlewi]

• This flag is deprecated and no longer used.

• The frontend should have stopped using this flag starting in 3.7.5

• The frontend is now up to 3.8.5

• So we should be good to remove this flag because the frontend should no longer be setting it.

• Related to Move AI Logging Of Execution Into VSCode Frontend and out of RunMe GRPC Server jlewi/foyle#211

[sourishkrout]

You doing push & pray over there 😆, @jlewi?

[jlewi]

You caught me.

[jlewi]

Lets try this again.

I fixed the build.

make build                       
CGO_ENABLED=0 go build -o runme -ldflags="-s -w -X 'github.com/stateful/runme/v3/internal/version.BuildDate=2024-10-04T00:33:55Z' -X 'github.com/stateful/runme/v3/internal/version.BuildVersion=3.8.3-2-ge50ed70-e50ed70' -X 'github.com/stateful/runme/v3/internal/version.Commit=e50ed7058be0f61a206168fd3467886e7202034e'" main.go

Lint gives me errors when running locally. But errors seem unrelated to any files I modified.

jlewi@~/git_runme#make lint
diff cmd/gqltool/main.go.orig cmd/gqltool/main.go
--- cmd/gqltool/main.go.orig
+++ cmd/gqltool/main.go
@@ -11,10 +11,9 @@
 	"github.com/stateful/runme/v3/internal/client/graphql"
 )
 
-var (
-	apiURL = flag.String("api-url", "http://localhost:4000", "The API base address")
-	// tokenDir = flag.String("token-dir", cmd.GetUserConfigHome(), "The directory with tokens")
-)
+var apiURL = flag.String("api-url", "http://localhost:4000", "The API base address")
+
+// tokenDir = flag.String("token-dir", cmd.GetUserConfigHome(), "The directory with tokens")
 
 func init() {
 	flag.Parse()
diff internal/runner/service.go.orig internal/runner/service.go
--- internal/runner/service.go.orig
+++ internal/runner/service.go
@@ -682,9 +682,7 @@
 		return nil, err
 	}
 
-	var (
-		modifiedScriptBuf bytes.Buffer
-	)
+	var modifiedScriptBuf bytes.Buffer
 
 	script := req.GetScript()
 	if commands := req.GetCommands(); script == "" && len(commands.Lines) > 0 {
diff internal/runnerv2service/service_resolve_program.go.orig internal/runnerv2service/service_resolve_program.go
--- internal/runnerv2service/service_resolve_program.go.orig
+++ internal/runnerv2service/service_resolve_program.go
@@ -26,9 +26,7 @@
 		return nil, err
 	}
 
-	var (
-		modifiedScriptBuf bytes.Buffer
-	)
+	var modifiedScriptBuf bytes.Buffer
 
 	script := req.GetScript()
 	if commands := req.GetCommands(); script == "" && len(commands.Lines) > 0 {
diff internal/telemetry/scarf.go.orig internal/telemetry/scarf.go
--- internal/telemetry/scarf.go.orig
+++ internal/telemetry/scarf.go
@@ -19,8 +19,10 @@
 	client = "Kernel"
 )
 
-type reporterFunc func() error
-type lookupEnvFunc func(key string) (string, bool)
+type (
+	reporterFunc  func() error
+	lookupEnvFunc func(key string) (string, bool)
+)
 
 var reporter reporterFunc

Also seeing some test failures locally.

    --- FAIL: TestRunnerServiceServerExecute_WithInput/SimulateCtrlC (1.51s)
        service_execute_test.go:842: 
            	Error Trace:	/Users/jlewi/git_runme/internal/runnerv2service/service_execute_test.go:842
            	Error:      	"rpc error: code = Unknown desc = exit status 1" does not contain "exit status 130"
            	Test:       	TestRunnerServiceServerExecute_WithInput/SimulateCtrlC
        service_execute_test.go:843: 
            	Error Trace:	/Users/jlewi/git_runme/internal/runnerv2service/service_execute_test.go:843
            	Error:      	Not equal: 
            	            	expected: 130
            	            	actual  : 1
            	Test:       	TestRunnerServiceServerExecute_WithInput/SimulateCtrlC

Looks in CI there is a test timeout now. Are tests known to be flaky?

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sourishkrout]

✅ LGTM. I have an eye on the flakes. I made them more stable on Linux but they still only seem to flake in GHA :-/.