Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Env Store (experimental) panel #1479

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Improvements to Env Store (experimental) panel #1479

merged 5 commits into from
Jul 31, 2024

Conversation

sourishkrout
Copy link
Member

@sourishkrout sourishkrout commented Jul 12, 2024 •
edited
Loading

  • Better tooltip visibility triggered by hovering over any value, not just the leading icon
  • Semantic sorting by error type, which brings invalid ENV vars to the top
  • Cosmetic tweaks

@sourishkrout sourishkrout force-pushed the seb-smart-env branch 3 times, most recently from e2c3d01 to 7fde059 Compare July 17, 2024 15:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 45%)

See analysis details on SonarCloud

pastuxso
pastuxso approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@pastuxso pastuxso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

src/client/components/env/store.ts Show resolved Hide resolved
@sourishkrout sourishkrout merged commit e7ebb9f into main Jul 31, 2024
3 of 4 checks passed
@sourishkrout sourishkrout deleted the seb-smart-env branch July 31, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pastuxso pastuxso pastuxso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sourishkrout @pastuxso