Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about unsupported shells #1550

Merged
merged 12 commits into from
Aug 28, 2024
Merged

Warn about unsupported shells #1550

merged 12 commits into from
Aug 28, 2024

Conversation

pastuxso
Copy link
Contributor

@pastuxso pastuxso commented Aug 16, 2024 •
edited
Loading

This PR introduces changes to make a best effort to determine if the shell is supported.

Progress: #1393

@pastuxso pastuxso force-pushed the cris/unsupported-shell-warn branch 5 times, most recently from cc669c3 to 9b8448f Compare August 16, 2024 18:55
@pastuxso pastuxso marked this pull request as ready for review August 17, 2024 02:17
sourishkrout
sourishkrout requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments.

src/extension/kernel.ts Outdated Show resolved Hide resolved
src/extension/extension.ts Outdated Show resolved Hide resolved
src/extension/extension.ts Outdated Show resolved Hide resolved
src/extension/kernel.ts Outdated Show resolved Hide resolved
src/extension/executors/aws.ts Show resolved Hide resolved
src/utils/configuration.ts Outdated Show resolved Hide resolved
@pastuxso pastuxso force-pushed the cris/unsupported-shell-warn branch 3 times, most recently from 2277ab6 to 46551d1 Compare August 20, 2024 22:09
@sourishkrout sourishkrout self-requested a review August 21, 2024 22:59
sourishkrout
sourishkrout requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

src/utils/configuration.ts Outdated Show resolved Hide resolved
src/utils/configuration.ts Outdated Show resolved Hide resolved
sourishkrout
sourishkrout requested changes Aug 21, 2024
View reviewed changes
src/extension/extension.ts Outdated Show resolved Hide resolved
src/extension/kernel.ts Outdated Show resolved Hide resolved
sourishkrout
sourishkrout requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting really close. More comments.

src/extension/kernel.ts Show resolved Hide resolved
src/extension/kernel.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
@sourishkrout
Copy link
Member

image

@pastuxso the early return is not being handled properly. in the case where grpcRunner is not true we don't want the error message aka we do want noop.

sourishkrout
sourishkrout requested changes Aug 27, 2024
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.9% Coverage on New Code (required ≥ 45%)

See analysis details on SonarCloud

sourishkrout
sourishkrout approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@sourishkrout sourishkrout merged commit f40f661 into main Aug 28, 2024
3 of 4 checks passed
@sourishkrout sourishkrout deleted the cris/unsupported-shell-warn branch August 28, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourishkrout sourishkrout sourishkrout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pastuxso @sourishkrout