Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger GhostCells On Cell Execution #1744

Merged
merged 15 commits into from
Oct 25, 2024
Merged

Trigger GhostCells On Cell Execution #1744

merged 15 commits into from
Oct 25, 2024

Commits on Oct 17, 2024

  1. Fix

    @jlewi
    jlewi committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    38e589f View commit details
    Browse the repository at this point in the history

  2. Cleanup.

    @jlewi
    jlewi committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    39a89f7 View commit details
    Browse the repository at this point in the history

  3. Update the comment.

    @jlewi
    jlewi committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    20d40a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Try to use onDidChangeActiveTextEditors and onDidChangeVisibleTextEdi… 

    …tors; that doesn't work. probably because the outputs aren't text editors.
    @jlewi
    jlewi committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    18e9cb7 View commit details
    Browse the repository at this point in the history

  2. Start hacking on using the notebook change event.

    @jlewi
    jlewi committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    dba2594 View commit details
    Browse the repository at this point in the history

  3. Success we appear to be successfully trigger when output updates and … 

    …output appears to get sent at least if the cell is non-interactive.
    @jlewi
    jlewi committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    53a6722 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Add comment.

    @jlewi
    jlewi committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    fee5aa1 View commit details
    Browse the repository at this point in the history

  2. Comment out changes to try to see why execution in non-interactive ce… 

    …lls is no longer working.
    @jlewi
    jlewi committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    2d650a6 View commit details
    Browse the repository at this point in the history

  3. Revert "Comment out changes to try to see why execution in non-intera… 

    …ctive cells is no longer working."

This reverts commit 2d650a6.
    @jlewi
    jlewi committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    10f7566 View commit details
    Browse the repository at this point in the history

  4. Cleanup.

    @jlewi
    jlewi committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    01ae804 View commit details
    Browse the repository at this point in the history

  5. Revert changes to trigger completions on doExecute. It seems redundant.

    @jlewi
    jlewi committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    26e982e View commit details
    Browse the repository at this point in the history

  6. Revert examples

    @jlewi
    jlewi committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    ccb8cfd View commit details
    Browse the repository at this point in the history

  7. Revert changes to contributing.md

    @jlewi
    jlewi committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    ed1d069 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Merge remote-tracking branch 'origin/main' into jlewi/ghost_markup

    @sourishkrout
    sourishkrout committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d2c7cd9 View commit details
    Browse the repository at this point in the history

  2. Add lock file

    @sourishkrout
    sourishkrout committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    6df333e View commit details
    Browse the repository at this point in the history