Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep stdout & stderr separate and standalone #773

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Keep stdout & stderr separate and standalone #773

merged 1 commit into from
Aug 15, 2023

Conversation

sourishkrout
Copy link
Member

@sourishkrout sourishkrout commented Aug 14, 2023 •
edited
Loading

We should be able to merge this independently from the terminal-based error code fix.

@sourishkrout sourishkrout marked this pull request as draft August 14, 2023 19:46
@sourishkrout sourishkrout marked this pull request as ready for review August 14, 2023 21:43
degrammer
degrammer approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@degrammer degrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sourishkrout sourishkrout merged commit 333c480 into main Aug 15, 2023
3 checks passed
@sourishkrout sourishkrout deleted the real-exit-code branch August 15, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@degrammer degrammer degrammer approved these changes

@duvanmonsa duvanmonsa duvanmonsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sourishkrout @duvanmonsa @degrammer