feat(core): add signal option to waitFor #5042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fef2f31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
boneskull
force-pushed
the
boneskull/wait-for-signal
branch
2 times, most recently
from
0516be1
to
804874f
Compare
Andarist
reviewed
Aug 17, 2024
boneskull
force-pushed
the
boneskull/wait-for-signal
branch
from
804874f
to
67e9227
Compare
davidkpiano
approved these changes
Aug 18, 2024
Andarist
reviewed
Aug 19, 2024
This PR adds a `signal?: AbortSignal` option to `WaitForOptions`, so that a call to `waitFor()` can be externally aborted.
boneskull
force-pushed
the
boneskull/wait-for-signal
branch
from
e74a808
to
fef2f31
Compare
Andarist
approved these changes
Aug 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
signal?: AbortSignaloption toWaitForOptions, so that a call towaitFor()can be externally aborted.