Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modified kvec for TERGM #578

Closed
wants to merge 2 commits into from

Conversation

AdrienLeGuillou
Copy link
Member

  • changes <stdlib.h> with <R.h>
  • replace calls to realloc and free to R_Realloc and R_Free

Contrary to KHash, no allocator macros are defined by default

related to statnet/tergm#125

- changes <stdlib.h> with <R.h>
- replace calls to realloc and free to R_Realloc and R_Free

Contrary to KHash, no allocator macros are defined by default
@krivit
Copy link
Member

krivit commented Sep 26, 2024

Hey, sorry take so long on this. Can I trouble you to use a development branch rather than master and make a PR from that? It makes it easier to test on my system.

@AdrienLeGuillou
Copy link
Member Author

Hi, no worries.
Do you mean making a dev branch on ergm and opening a PR from it to master?
I am not allowed to create branches on this repo though.

@krivit
Copy link
Member

krivit commented Sep 26, 2024

The idea is to keep AdrienLeguillou/ergm@master identical to statnet/ergm@master at all times, and make a PR from AdrienLeguillou/ergm@kvec to statnet/ergm@master .

@krivit
Copy link
Member

krivit commented Sep 26, 2024

That way, I can check out your dev branch and make edits and comparisons as needed.

@AdrienLeGuillou
Copy link
Member Author

got it

@AdrienLeGuillou AdrienLeGuillou deleted the branch statnet:master September 26, 2024 09:20
@AdrienLeGuillou AdrienLeGuillou deleted the master branch September 26, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants