-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix setMaxSupply to check total minted #27
Conversation
function setMaxSupply( | ||
uint256 newMaxSupply | ||
) external virtual onlyCommunityOwnerOrTokenMaster { | ||
if (newMaxSupply < mintedCount()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me, but the formatting seems off (which is probably why this isn't passing the linter on CI).
Can you please update this accordingly?
Also, it'd be wonderful if this had a dedicated certora rule that ensures this works as expected. I've started something here #28 |
This is unfortunately still not passing the prover. |
Another invariant is failing similar to what I've pointed out here: #28 (comment) I wonder if this is related to the |
Approved changes. Great job! |
closes #36
Description
Describe the changes made in your pull request here.
including specs from #28
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot
?pnpm lint
?forge test
?pnpm verify
?