refactor: use immutable properties where possible #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
commented
Sep 4, 2023
contracts/OwnerToken.sol
Outdated
| MasterToken masterToken = new MasterToken(_masterName, _masterSymbol, _masterBaseTokenURI, address(this)); | ||
| emit MasterTokenCreated(address(masterToken)); | ||
| MasterToken _masterToken = new MasterToken(_masterName, _masterSymbol, _masterBaseTokenURI, address(this)); | ||
| emit MasterTokenCreated(address(_masterToken)); |
There was a problem hiding this comment.
This change isn't strictly necessary, but slither complained that masterToken would shadow BaseToken.masterToken, so I guess it wouldn't hurt to make slither happy here..
0x-r4bbit
force-pushed
the
refactor/gas-optimizations
branch
from
91c076b to
c5aabdb
Compare
0x-r4bbit
force-pushed
the
refactor/use-immutable
branch
from
29d606d to
eba81f7
Compare
0x-r4bbit
force-pushed
the
refactor/gas-optimizations
branch
from
c5aabdb to
5a0eded
Compare
0x-r4bbit
force-pushed
the
refactor/use-immutable
branch
from
eba81f7 to
b21d7da
Compare
0x-r4bbit
force-pushed
the
refactor/gas-optimizations
branch
from
5a0eded to
8c6da1a
Compare
0x-r4bbit
force-pushed
the
refactor/use-immutable
branch
from
b21d7da to
c3a67d2
Compare
0x-r4bbit
force-pushed
the
refactor/gas-optimizations
branch
from
8c6da1a to
1707f9e
Compare
0x-r4bbit
force-pushed
the
refactor/use-immutable
branch
from
c3a67d2 to
9d8d19d
Compare
This commit changes a few token properties to be `immutable` as this reduces gas costs even further. This was reported by Slither. A gas report with changes in gas cost is attached.
0x-r4bbit
force-pushed
the
refactor/use-immutable
branch
from
9d8d19d to
d316475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes a few token properties to be
immutableas this reduces gas costs even further.This was reported by Slither.
A gas report with changes in gas cost is attached.