Vault withdrawn untracked #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
@0xb337r007 very nice and clean. I've only reviewed the third commit.
Only thing I'm missing here are natspec comments.
Would you mind adding them here?
| IERC721(token).safeTransferFrom(address(this), recipients[i], tokenIds[i]); | ||
| } | ||
| } | ||
|
|
||
| function withdrawUntrackedERC20( |
There was a problem hiding this comment.
Can we get some natspec pretty please?
| IERC20(tokenAddress).safeTransfer(to, amount); | ||
| } | ||
|
|
||
| function withdrawUntrackedERC721( |
gravityblast
force-pushed
the
vault-withdrawn-untracked-3
branch
from
ec4eff8 to
305483e
Compare
gravityblast
force-pushed
the
vault-withdrawn-untracked-3
branch
from
305483e to
d74f44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #53 to be merged first
Description
closes #54
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm lint?forge test?pnpm verify?