Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add migration feature #62

Merged
merged 1 commit into from
May 16, 2024
Merged

add migration feature #62

merged 1 commit into from
May 16, 2024

Conversation

0xb337r007
Copy link
Collaborator

@0xb337r007 0xb337r007 commented Mar 25, 2024

Description

Describe the changes made in your pull request here.

closes #33

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Added natspec comments?
  • Ran forge snapshot?
  • Ran pnpm lint?
  • Ran forge test?
  • Ran pnpm verify?

@0xb337r007 0xb337r007 marked this pull request as draft March 25, 2024 09:54
@0x-r4bbit
Copy link
Member

@0xb337r007 what's the state of this? Is this ready for review?

@0x-r4bbit
Copy link
Member

Another ping here

@gravityblast gravityblast force-pushed the feat/migrate-tokens branch from 4533f32 to b834d48 Compare May 16, 2024 00:36
@gravityblast gravityblast marked this pull request as ready for review May 16, 2024 00:37
Copy link
Member

@0x-r4bbit 0x-r4bbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

One tiny thing: I'm not sure feature():... is conventional commits compliant

@gravityblast gravityblast force-pushed the feat/migrate-tokens branch from b834d48 to 6dbce62 Compare May 16, 2024 09:19
@0xb337r007 0xb337r007 merged commit aacd7fd into main May 16, 2024
5 checks passed
@0xb337r007 0xb337r007 deleted the feat/migrate-tokens branch May 16, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement migration strategy for community vaults
2 participants