Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guarantee exclusive use of HttpClientConnection. #273

Merged
merged 1 commit into from
May 12, 2022
Merged

Guarantee exclusive use of HttpClientConnection. #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions chronos/apps/http/httpclient.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ type
Resolving, ## Resolving remote hostname
Connecting, ## Connecting to remote server
Ready, ## Connected to remote server
Acquired, ## Connection is acquired for use
RequestHeadersSending, ## Sending request headers
RequestHeadersSent, ## Request headers has been sent
RequestBodySending, ## Sending request body
Expand Down Expand Up @@ -583,6 +584,7 @@ proc acquireConnection(session: HttpSessionRef,
await session.connect(ha).wait(session.connectTimeout)
except AsyncTimeoutError:
raiseHttpConnectionError("Connection timed out")
res[].state = HttpClientConnectionState.Acquired
session.connections.mgetOrPut(ha.id, default).add(res)
return res
else:
Expand All @@ -599,6 +601,7 @@ proc acquireConnection(session: HttpSessionRef,
else:
nil
if not(isNil(conn)):
conn[].state = HttpClientConnectionState.Acquired
return conn
else:
var default: seq[HttpClientConnectionRef]
Expand All @@ -607,6 +610,7 @@ proc acquireConnection(session: HttpSessionRef,
await session.connect(ha).wait(session.connectTimeout)
except AsyncTimeoutError:
raiseHttpConnectionError("Connection timed out")
res[].state = HttpClientConnectionState.Acquired
session.connections.mgetOrPut(ha.id, default).add(res)
return res

Expand Down