Skip to content

Commit

Permalink
Remove git rev from ENR client info
Browse files Browse the repository at this point in the history
This allows for a shorter ENR which allows more ENRs to be packed
in the Nodes reply. And for glados, only the client name is used
anyhow.
  • Loading branch information
kdeme committed Sep 20, 2023
1 parent 9171359 commit e3ed5d3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions fluffy/fluffy.nim
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,10 @@ proc run(config: PortalConf) {.raises: [CatchableError].} =
d = newProtocol(
netkey,
extIp, none(Port), extUdpPort,
# Note: The addition of clientInfo to the ENR is a temporary measure to
# easily identify & debug the clients used in the testnet.
localEnrFields = {"c": clientInfoShort},
# Note: The addition of default clientInfo to the ENR is a temporary
# measure to easily identify & debug the clients used in the testnet.
# Might make this into a, default off, cli option.
localEnrFields = {"c": enrClientInfoShort},
bootstrapRecords = bootstrapRecords,
bindIp = bindIp, bindPort = udpPort,
enrAutoUpdate = config.enrAutoUpdate,
Expand Down
4 changes: 2 additions & 2 deletions fluffy/version.nim
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ const
copyrightBanner* =
"Copyright (c) 2021-" & compileYear & " Status Research & Development GmbH"

# Short debugging indentifier for ENR
clientInfoShort* = toBytes("f-" & gitRevision)
# Short debugging identifier to be placed in the ENR
enrClientInfoShort* = toBytes("f")

func getNimGitHash*(): string =
const gitPrefix = "git hash: "
Expand Down

0 comments on commit e3ed5d3

Please sign in to comment.