Ledger activate unified accounts cache wrapper #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
details: `accounts_cache.nim` methods are indirectly processed by the wrapper methods from `ledger.nim`. This works for all sources except `test_state_db.nim` where the source `accounts_cache.nim` is included (rather than imported) in order to access objects privy to the very source.
details: Can be set as suggestion when initialising `CommonRef`
details: + Allow time logging by pre-defined block intervals + Print `CoreDb`/`Ledger`profiling results (if enabled)
bhartnett
pushed a commit
that referenced
this pull request
Dec 18, 2023
* Activate `LedgerRef` wrapper for `AccountsCache` details: `accounts_cache.nim` methods are indirectly processed by the wrapper methods from `ledger.nim`. This works for all sources except `test_state_db.nim` where the source `accounts_cache.nim` is included (rather than imported) in order to access objects privy to the very source. * Provide facility to switch to a preselected `LedgerRef` type details: Can be set as suggestion when initialising `CommonRef` * Update `CoreDb` test suite for better time tracking details: + Allow time logging by pre-defined block intervals + Print `CoreDb`/`Ledger`profiling results (if enabled)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.