Update the beacon and state network content key prefixes #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Portal specifications were adjusted so that the content key prefixes become unique selectors over all networks. Fixes issue #1924 SSZ Union is still used, but it could be that in the future we need to move to our own custom serialization here. The unused enum value and the fact that we have to add these to the case of is quite annoying but unless we stop using a case object seems not avoidable.
mynameisdaniil
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Portal specifications were adjusted so that the content key prefixes become unique selectors over all networks.
Fixes issue #1924
SSZ Union is still used, but it could be that in the future we need to move to our own custom serialization here.
The unused enum value and the fact that we have to add these to the case of is quite annoying but unless we stop using a case object seems not avoidable.