Doppelganger exit code changed from 1031 to 129 (addresses #3973) (#3977

)
status-im · Aug 17, 2022 · ca3245c · ca3245c
1 parent fa9e2b4
commit ca3245c
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -99,7 +99,7 @@ Nimbus `v22.6.0` brings support for the merge testnets Ropsten and Sepolia (plea
   https://github.com/status-im/nimbus-eth2/pull/3679
   https://github.com/status-im/nimbus-eth2/pull/3780
 
-* The custom error code `1031` will signal a detected doppelganger on the network. This can be handled in the Nimbus's service supervisor to prevent an automatic restart:
+* The custom error code `129` will signal a detected doppelganger on the network. This can be handled in the Nimbus's service supervisor to prevent an automatic restart:
   https://github.com/status-im/nimbus-eth2/pull/3728
 
 * The Nimbus status bar can be configured to display the current version number:

diff --git a/beacon_chain/gossip_processing/eth2_processor.nim b/beacon_chain/gossip_processing/eth2_processor.nim
@@ -287,7 +287,7 @@ proc checkForPotentialDoppelganger(
 
         # Avoid colliding with
         # https://www.freedesktop.org/software/systemd/man/systemd.exec.html#Process%20Exit%20Codes
-        const QuitDoppelganger = 1031
+        const QuitDoppelganger = 129
         quit QuitDoppelganger
 
 proc processAttestation*(

diff --git a/docs/the_nimbus_book/src/beacon-node-systemd.md b/docs/the_nimbus_book/src/beacon-node-systemd.md
@@ -35,7 +35,7 @@ curl -s https://raw.githubusercontent.com/status-im/nimbus-eth2/stable/scripts/p
 The format of service files is documented in the [systemd manual](https://www.freedesktop.org/software/systemd/man/systemd.service.html).
 
 !!! tip
-    Automatic restarts increase the risk that the doppelganger detection fails - set `RestartPreventExitStatus=1031` to prevent this from happening
+    Automatic restarts increase the risk that the doppelganger detection fails - set `RestartPreventExitStatus=129` to prevent this from happening
 
 ### 3. Configure your service
 

diff --git a/docs/the_nimbus_book/src/options.md b/docs/the_nimbus_book/src/options.md
@@ -144,8 +144,8 @@ Here is an example config file illustrating all of the above:
 
 ## Exit Codes
 
-| Exit code | Description |
-|-----------|---------|
-| 0 |  Successful exit |
-| 1 | Generic failure or unspecified error |
-| 1031 | Doppelganger detection; one might prefer not to restart automatically |
+| Exit code | Description                                                           |
+|-----------|-----------------------------------------------------------------------|
+| 0         | Successful exit                                                       |
+| 1         | Generic failure or unspecified error                                  |
+| 129       | Doppelganger detection; one might prefer not to restart automatically |
diff --git a/scripts/package_image/usr/lib/systemd/system/nimbus_beacon_node.service b/scripts/package_image/usr/lib/systemd/system/nimbus_beacon_node.service
@@ -51,7 +51,7 @@ TimeoutSec=1200
 Restart=always
 
 # Don't restart when Doppelganger detection has been activated
-RestartPreventExitStatus=1031
+RestartPreventExitStatus=129
 
 ExecStart=/usr/bin/nimbus_beacon_node \
   --network=${NETWORK} \