Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyManager API do not follows specification when importing keys. #3760

Closed
cheatfate opened this issue Jun 16, 2022 · 1 comment · Fixed by #3768
Closed

KeyManager API do not follows specification when importing keys. #3760

cheatfate opened this issue Jun 16, 2022 · 1 comment · Fixed by #3768
Assignees

Comments

@cheatfate
Copy link
Contributor

This keystore request could not be processed by nimbus keystore manager api.

{"keystores": ["{\"crypto\": {\"kdf\": {\"function\": \"scrypt\", \"params\": {\"dklen\": 32, \"n\": 262144, \"r\": 8, \"p\": 1, \"salt\": \"zzz\"}, \"message\": \"\"}, \"checksum\": {\"function\": \"sha256\", \"params\": {}, \"message\": \"zzz\"}, \"cipher\": {\"function\": \"aes-128-ctr\", \"params\": {\"iv\": \"a24857026939492f49444679544cb6bb\"}, \"message\": \"zzzz\"}}, \"description\": \"\", \"pubkey\": \"zzzz\", \"path\": \"m/12381/3600/0/0/0\", \"uuid\": \"1ea9ed13-e3bb-4555-99d9-c5e83ab9eb67\", \"version\": 4}"], "passwords": ["MyTestPassword"]}

keystores array should be filled with strings, not objects.
https://github.com/ethereum/keymanager-APIs/blob/master/types/keystore.yaml

@cheatfate cheatfate self-assigned this Jun 16, 2022
@cheatfate
Copy link
Contributor Author

slashing_protection should be treated as json string too.

cheatfate added a commit that referenced this issue Jun 16, 2022
Add test vectors for deserialization.
@cheatfate cheatfate mentioned this issue Jun 16, 2022
@etan-status etan-status linked a pull request Jun 16, 2022 that will close this issue
@zah zah closed this as completed in c4383e2 Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant