New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use libbacktrace on Windows #2556

Closed

stefantalpalaru wants to merge 1 commit into unstable from backtrace

Contributor

stefantalpalaru commented May 11, 2021

No description provided.

github-actions bot commented May 11, 2021 •

edited

Loading

Unit Test Results linux-amd64

    8 files ±0   56 suites ±0 52s ⏱️ +2s
523 tests ±0 503 ✔️ ±0 20 💤 ±0 0 ❌ ±0
589 runs ±0 560 ✔️ ±0 29 💤 ±0 0 ❌ ±0

Results for commit 81dc4e0. ± Comparison against base commit 149ff49.

♻️ This comment has been updated with latest results.

github-actions bot commented May 11, 2021 •

edited

Loading

Unit Test Results macos-amd64

    8 files ±0   56 suites ±0 50s ⏱️ - 1m 15s
523 tests ±0 503 ✔️ ±0 20 💤 ±0 0 ❌ ±0
589 runs ±0 560 ✔️ ±0 29 💤 ±0 0 ❌ ±0

Results for commit 81dc4e0. ± Comparison against base commit 149ff49.

♻️ This comment has been updated with latest results.

github-actions bot commented May 11, 2021 •

edited

Loading

Unit Test Results linux-i386

    8 files ±0   56 suites ±0 2m 40s ⏱️ +2s
523 tests ±0 503 ✔️ ±0 20 💤 ±0 0 ❌ ±0
589 runs ±0 560 ✔️ ±0 29 💤 ±0 0 ❌ ±0

Results for commit 81dc4e0. ± Comparison against base commit 149ff49.

♻️ This comment has been updated with latest results.

github-actions bot commented May 11, 2021 •

edited

Loading

Unit Test Results windows-amd64

    8 files ±0   56 suites ±0 1m 7s ⏱️ - 2m 15s
523 tests ±0 503 ✔️ ±0 20 💤 ±0 0 ❌ ±0
589 runs ±0 560 ✔️ ±0 29 💤 ±0 0 ❌ ±0

Results for commit 81dc4e0. ± Comparison against base commit 149ff49.

♻️ This comment has been updated with latest results.

github-actions bot commented May 11, 2021 •

edited

Loading

Unit Test Results

    28 files ±0   328 suites ±0 7m 58s ⏱️ - 6m 42s
  625 tests ±0   607 ✔️ ±0   18 💤 ±0 0 ❌ ±0
3 428 runs ±0 3 324 ✔️ ±0 104 💤 ±0 0 ❌ ±0

Results for commit 111c515. ± Comparison against base commit 0fb02b5.

♻️ This comment has been updated with latest results.

Contributor Author

stefantalpalaru commented May 11, 2021

And we have a new record for the fastest overall CI run: 35m 45s - https://github.com/status-im/nimbus-eth2/actions.html?page=1&workflow_file_name=ci.yml

Contributor

cheatfate commented May 11, 2021

I would not recommend to merge this PR. I had a lot of crashes on Windows with nim-libbacktrace enabled. And i haven't see any crashes while it was disabled.

Contributor Author

stefantalpalaru commented May 11, 2021

The libunwind bug you were affected by was fixed upstream: llvm/llvm-project@542db87

Contributor

zah commented May 11, 2021

How can we merge this in a responsible way? It looks like we'll need macOS and Windows nodes on the fleet to subject to the appropriate level of testing.

Contributor Author

stefantalpalaru commented May 11, 2021

It works in CI and there's a way to opt out by passing USE_LIBBACKTRACE=0 to Make.
No extraordinary testing needed.

Contributor

cheatfate commented May 17, 2021 •

edited

Loading

The libunwind bug you were affected by was fixed upstream: llvm/llvm-project@542db87

LOL, you didn't believe that it was libbacktrace/libunwind bug, you was saying it was our hidden bug inside of our code, and it was impossible to convince you otherwise...

Contributor Author

stefantalpalaru commented May 17, 2021

Even I am wrong, sometimes :-)


          use libbacktrace on Windows

111c515

stefantalpalaru force-pushed the backtrace branch from 81dc4e0 to 111c515 Compare

June 2, 2021 00:39

stefantalpalaru changed the title ~~use libbacktrace on macOS and Windows~~ use libbacktrace on Windows

arnetheduck force-pushed the unstable branch 2 times, most recently from 657f9d5 to a4667d1 Compare

January 6, 2022 16:14

Base automatically changed from unstable to stable

February 15, 2022 20:57

tersec changed the base branch from stable to unstable

March 19, 2022 07:48

Contributor Author

stefantalpalaru commented Mar 21, 2022

Superseded by #3466

stefantalpalaru closed this

stefantalpalaru deleted the backtrace branch

March 21, 2022 08:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet