relax BlockRef database assumptions
#3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
force-pushed
the
rm-gfbbr
branch
3 times, most recently
from
daf4993
to
8df2abb
Compare
* remove `getForkedBlock(BlockRef)` which assumes block data exists but doesn't support archive/backfilled blocks * fix REST `/eth/v1/beacon/headers` request not returning archive/backfilled blocks * avoid re-encoding in REST block SSZ requests (using `getBlockSSZ`)
mratsim
reviewed
Mar 8, 2022
| @@ -198,7 +198,7 @@ func toBlockSlotId*(bs: BlockSlot): BlockSlotId = | |||
|
|
|||
| func isProposed*(bid: BlockId, slot: Slot): bool = | |||
| ## Return true if `bid` was proposed in the given slot | |||
| bid.slot == slot | |||
| bid.slot == slot and not bid.root.isZero | |||
There was a problem hiding this comment.
Do we have a test for that? Or in which situation do we get a 0 block id (backfill?)
There was a problem hiding this comment.
zero is returned if the block is not found (should probably change that to Option at some point but .. ) - there were tests but they didn't cover zero
| data.signature.toRaw() != signed_beacon_block.signature.toRaw(): | ||
| return errIgnore("BeaconBlock: already proposed in the same slot") | ||
| let curBlock = dag.getForkedBlock(slotBlock.blck.bid) | ||
| if curBlock.isOk(): |
There was a problem hiding this comment.
Nothing happens if the curBlock is an error?
There was a problem hiding this comment.
nothing - we don't have the block so there's nothing to compare with (should typically not happen, except in weird timing scenarios)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getForkedBlock(BlockRef)which assumes block data exists butdoesn't support archive/backfilled blocks
/eth/v1/beacon/headersrequest not returningarchive/backfilled blocks
getBlockSSZ)