Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Nim 1.6 build deprecation warnings #3712

Merged
merged 1 commit into from
Jun 9, 2022
Merged

fix Nim 1.6 build deprecation warnings #3712

merged 1 commit into from
Jun 9, 2022

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Jun 7, 2022

This fixes 3 warnings, each of which individually appears 10 times in a full (make test && make) build:

beacon_chain/consensus_object_pools/block_quarantine.nim(158, 27) Warning: Deprecated since v1.4; it was more confusing than useful, use `[]=`; add is deprecated [Deprecated]
beacon_chain/consensus_object_pools/block_quarantine.nim(162, 23) Warning: Deprecated since v1.4; it was more confusing than useful, use `[]=`; add is deprecated [Deprecated]
beacon_chain/consensus_object_pools/block_quarantine.nim(204, 25) Warning: Deprecated since v1.4; it was more confusing than useful, use `[]=`; add is deprecated [Deprecated]

add and []= aren't identical, but in this case, []= is better anyway, since it can't add duplicate blocks.

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Unit Test Results

     12 files  ±0     842 suites  ±0   59m 59s ⏱️ + 3m 16s
1 699 tests ±0  1 647 ✔️ ±0    52 💤 ±0  0 ❌ ±0 
9 893 runs  ±0  9 765 ✔️ ±0  128 💤 ±0  0 ❌ ±0 

Results for commit 19eee64. ± Comparison against base commit 3e7d3bb.

@zah zah merged commit 83793c3 into unstable Jun 9, 2022
@zah zah deleted the MgY branch June 9, 2022 09:09
etan-status added a commit that referenced this pull request Jun 10, 2022
@etan-status
Merge commit '15967c407639ac48fcecf52f727555dae18a14b5' into dev/etan…
37fe03a 
…/lc-dbprep

* commit '15967c407639ac48fcecf52f727555dae18a14b5':
  keep track of latest blocks for optimistic sync (#3715)
  separate non-zero exit code for doppelganger detection (#3728)
  cleanups: unused and duplicate imports, inconsistent naming conventions, URL updates (#3724)
  Change the log level for unrecognized json fields from debug to trace
  ncli: altair+ slot and state transitions (#3721)
  fix Nim 1.6 build deprecation warnings (#3712)
  remove unused stdlib imports (#3718)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tersec @zah