Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set safe_block_hash to fork choice justified #4010

Merged
merged 5 commits into from
Aug 25, 2022

Conversation

etan-status
Copy link
Contributor

Implements the fork choice safe block spec, where safe_block_hash in
forkChoiceUpdated is set to justified (used to be ZERO_HASH).
https://github.com/ethereum/consensus-specs/blob/v1.2.0-rc.3/fork_choice/safe-block.md#get_safe_execution_payload_hash

Implements the fork choice safe block spec, where `safe_block_hash` in
`forkChoiceUpdated` is set to justified (used to be `ZERO_HASH`).
https://github.com/ethereum/consensus-specs/blob/v1.2.0-rc.3/fork_choice/safe-block.md#get_safe_execution_payload_hash
@github-actions
Copy link

github-actions bot commented Aug 21, 2022

Unit Test Results

       12 files  ±0       860 suites  ±0   1h 13m 15s ⏱️ - 10m 3s
  1 987 tests ±0    1 840 ✔️ ±0  147 💤 ±0  0 ±0 
10 682 runs  ±0  10 492 ✔️ ±0  190 💤 ±0  0 ±0 

Results for commit 01ba456. ± Comparison against base commit c65eaca.

♻️ This comment has been updated with latest results.

@etan-status etan-status requested a review from tersec August 25, 2022 18:32
@etan-status etan-status enabled auto-merge (squash) August 25, 2022 21:19
@etan-status etan-status merged commit 64972e3 into unstable Aug 25, 2022
@etan-status etan-status deleted the dev/etan/os-safeblock branch August 25, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants