remove incorrect block gossip validation condition #4044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was excessively aggressive and could cause a deadlock in recovery of EL sync verification.
It was an implementation of https://github.com/ethereum/consensus-specs/blob/dev/specs/bellatrix/p2p-interface.md#beacon_block:
However, because Nimbus always completes
execution_payload
verification by the time a block reaches the DAG, this can't ever happen. The first thing Nimbus does is to ask the EL, and wait for the EL's reply eitherACCEPTED
orSYNCING
, because optimistic sync requires this anyway. So by the time it reaches here, the only relevant condition iswhich is already handled.