Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harden exchangeTransitionConfiguration retries #4095

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

etan-status
Copy link
Contributor

p.dataProvider may become nil between individual attempts to exchange transition configuration with the EL. Harden by capturing the data provider on function start.

Note that other functions are already hardened, or are unaffected. Only close transitions p.dataProvider to nil, and close is only called by the main deposits import sequence. During the deposits import, close is not called, so extra checks are not needed.

`p.dataProvider` may become `nil` between individual attempts to
exchange transition configuration with the EL. Harden by capturing
the data provider on function start.

Note that other functions are already hardened, or are unaffected.
Only `close` transitions `p.dataProvider` to `nil`, and `close` is
only called by the main deposits import sequence. During the deposits
import, `close` is not called, so extra checks are not needed.
@etan-status etan-status linked an issue Sep 8, 2022 that may be closed by this pull request
@arnetheduck arnetheduck merged commit e6b8bc6 into unstable Sep 8, 2022
@arnetheduck arnetheduck deleted the dev/etan/el-exchangeretry branch September 8, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGSEGV when reconnecting to the EL after a connection failure
2 participants