Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't consider stubbed terminal block hash terminal (fixes #4094) #4096

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Don't consider stubbed terminal block hash terminal (fixes #4094) #4096

merged 1 commit into from
Sep 8, 2022

Conversation

arnetheduck
Copy link
Member

No description provided.

@arnetheduck arnetheduck merged commit ee1465e into unstable Sep 8, 2022
@arnetheduck arnetheduck deleted the stubbed-hash branch September 8, 2022 08:57
etan-status
etan-status reviewed Sep 8, 2022
View reviewed changes
beacon_chain/eth1/eth1_monitor.nim
Comment on lines +593 to +596
info "Exchanged engine configuration",
ttd = executionCfg.terminalTotalDifficulty,
terminalBlockHash = executionCfg.terminalBlockHash,
terminalBlockNumber = executionCfg.terminalBlockNumber.uint64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is quite useful, also to verify that the EL connection is indeed working fine.

@etan-status etan-status linked an issue Sep 8, 2022 that may be closed by this pull request
Missed proposal getExecutionPayload: newExecutionPayload invalid #4094
Closed
@etan-status
Copy link
Contributor

Validated fix using launch_local_testnet.

@etan-status
Copy link
Contributor 

rm -rf local_testnet_data && scripts/launch_local_testnet.sh \
  --kill-old-processes --preset minimal --disable-htop --disable-vc --run-geth --dl-geth -- \
  --log-format=auto --max-peers=160

I ran this before this patch, and after this patch.

Without patch, network got stuck around block 17 and same message got logged about engine API usage. With patch, network proceeded as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etan-status etan-status etan-status left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missed proposal getExecutionPayload: newExecutionPayload invalid
2 participants
@arnetheduck @etan-status