Fix and document some usages of defaultRuntimeConfig #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Sep 19, 2022
etan-status
reviewed
Sep 19, 2022
arnetheduck
reviewed
Sep 19, 2022
Closed
|
The windows test failure here looks consistent, so it should be looked into before merging |
|
The failure was tracked down to the fact that we were not using the latest Nim 1.6 fixes because the respective branch in the Status Nim repo was stale. |
arnetheduck
approved these changes
Oct 14, 2022
zah
force-pushed
the
4134-follow-up
branch
2 times, most recently
from
d4cf0b9
to
86485ac
Compare
arnetheduck
added a commit
that referenced
this pull request
Nov 8, 2022
Without this, tools like `ncli_db` require command line parameter to process mainnet blocks, which is a regression since the merge - this is a subset of #4147.
arnetheduck
added a commit
that referenced
this pull request
Nov 8, 2022
Without this, tools like `ncli_db` require command line parameter to process mainnet blocks, which is a regression since the merge - this is a subset of #4147.
Other changes: * Make the light client store compatible with phase0-only networks and simulations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4134 follow-up work, discussed here:
#4134 (comment)