REST API: add ssz encoding for publishBlock #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etan-status
approved these changes
Sep 20, 2022
Comment on lines
782
to
784
| if forked.kind != node.dag.cfg.blockForkAtEpoch( | ||
| getForkedBlockField(forked, slot).epoch): | ||
| getForkedBlockField(forked, slot).epoch): | ||
| return RestApiResponse.jsonError(Http400, InvalidBlockObjectError) |
There was a problem hiding this comment.
Hmm, I think this check should be moved to gossip_validation.validateBeaconBlock (so that it applies to all sources of blocks). It's also a new check that wasn't present in the pure JSON version.
There was a problem hiding this comment.
nope it was there too.
There was a problem hiding this comment.
gossip checks this implicitly via signature check, if nothing else
arnetheduck
reviewed
Sep 28, 2022
Co-authored-by: Etan Kissling <etan@status.im>
cheatfate
force-pushed
the
ssz-publish-block
branch
from
a83f983
to
2de8412
Compare
arnetheduck
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ethereum.github.io/beacon-APIs/#/Beacon/publishBlock implementation for SSZ encoded blocks.