implement /eth/v1/beacon/blinded_blocks BN endpoint #4286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Nov 8, 2022
arnetheduck
reviewed
Nov 8, 2022
| # From here on, including error paths, disallow local EL production by | ||
| # returning Opt.some, regardless of whether on head or newBlock. | ||
| except RestDecodingError as exc: | ||
| error "unblindAndRouteBlockMEV: REST decoding error submitting blinded block", |
There was a problem hiding this comment.
avoid function names in non-debug logs - also, both logging and returning an error creates unclarity as to whose responsibility it is to log
There was a problem hiding this comment.
1a3ca5f removes the unblindAndRouteBlockMEV error logging, after verification that both BN and VC calling codepaths adequately log this.
arnetheduck
approved these changes
Nov 8, 2022
arnetheduck
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.