Switch to official doppelganger detection implementation. #4381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch VC to use /eth/v1/validator/liveness/{epoch} endpoint instead of nimbus one.
arnetheduck
reviewed
Dec 6, 2022
| return RestApiResponse.jsonError(Http400, InvalidEpochValueError, | ||
| "Requested epoch is more than one epoch from current epoch") | ||
| res | ||
| indexList = |
There was a problem hiding this comment.
reading the index list should really be a function, given how we read the same list in several places (attestations etc)
arnetheduck
reviewed
Dec 6, 2022
| var index: Option[ValidatorIndex] | ||
| var isLive: Option[bool] | ||
|
|
||
| for fieldName in readObjectFields(reader): |
There was a problem hiding this comment.
why does this need a custom reader? isn't it simple enough?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch VC to use /eth/v1/validator/liveness/{epoch} endpoint instead of nimbus one.