remove all but truly stub support for SHARDING_FORK_{EPOCH,VERSION}
#4385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, its only appearances in the
consensus-specs
repository areThat is, it does not have any defined semantics, and it exists solely as a set of
TODO
s and boundary conditions.https://github.com/eth-clients/eth2-networks and https://github.com/eth-clients/merge-testnets network definitions do to contain it, so this PR does not remove the
spec/presets
RuntimeConfig
support for reading in that field from a such a network configuration. However,checkForkConsistency
then asserts unconditionally thatSHARDING_FORK_EPOCH
isFAR_FUTURE_EPOCH
and otherwise ignores it.This PR was prompted by #4365 discovering that there's a spurious conflict between certain definitions of
EIP4844_FORK_VERSION
andSHARDING_FORK_VERSION
, when the latter is irrelevant.