Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable validator monitor by default #4468

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Enable validator monitor by default #4468

merged 4 commits into from
Jan 16, 2023

Commits on Jan 15, 2023

  1. Enable validator monitor by default 

    By enabling the validator monitor, more precise information about the
lifecycle of an attestation is logged at the higher `NOTICE` log level
while current `sent` messages are logged at `INF` instead, since they
are less interesting.

In particular, missed attestations and those that vote for the wrong
head are now detected and logged at NOTICE.

In addition to logging, this feature enables rich metrics around
attestation and sync committee performance - by default, validators are
tracked in aggregate but a detailed mode exists as well

This feature has been available since early Nimbus days, but it has now
been tuned and optimised such that it is safe to enable by default, even
for large setups.

* enable automatic validator monitoring by default
* replace `--validator-monitor-totals` flag with
`--validator-monitor-details` - the detailed mode is disabled by default
* lower "sent" log level to `INF` for several messages - in particular
those that are traced by the validator monitor

This is a retake on #3531 which was later reverted in #3578.
    @arnetheduck
    arnetheduck committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    4b88566 View commit details
    Browse the repository at this point in the history

  2. doc style

    @arnetheduck
    arnetheduck committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    edbebb2 View commit details
    Browse the repository at this point in the history

  3. more manual updates

    @arnetheduck
    arnetheduck committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    e38656f View commit details
    Browse the repository at this point in the history

  4. avoid redundant logging of deep attestation misses

    @arnetheduck
    arnetheduck committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    12fef9b View commit details
    Browse the repository at this point in the history