query EL and builder relay for bids in parallel #4749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
force-pushed
the
2BY
branch
2 times, most recently
from
eca4010
to
88e5ded
Compare
tersec
force-pushed
the
2BY
branch
2 times, most recently
from
1613e02
to
5a64bee
Compare
tersec
changed the title
tersec
force-pushed
the
2BY
branch
3 times, most recently
from
f8924bb
to
e160bcd
Compare
zah
reviewed
Apr 4, 2023
|
|
||
| let useBuilderBlock = | ||
| if builderBidAvailable: | ||
| if engineBidAvailable: |
There was a problem hiding this comment.
Both branches of this if statement return true?
There was a problem hiding this comment.
Yes, one of them's the point where the bid comparison will be placed. The other will remain unconditionally true, because there's no alternative, because the engine bid didn't arrive.
| res.get() | ||
|
|
||
| template proposeBlockContinuation(type1, type2: untyped): auto = | ||
| await proposeBlockAux[type1, type2]( |
There was a problem hiding this comment.
I'm usually migrating all explicit generic parameters to typedesc parameters, because the former have number of shortcomings in the compiler (e.g. limited ability to overload, lack of default values, more bugs).
Co-authored-by: zah <zahary@status.im>
Co-authored-by: zah <zahary@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VC implementation has tradeoffs, but among them is that it doesn't have the tight coupling this PR moves towards breaking up a bit.