only add active validators to knownValidators at startup #4793
Conversation
| template v: auto = forkyState.data.validators.item(idx) | ||
| if is_active_validator(v, wallSlot.epoch) or | ||
| is_active_validator(v, wallSlot.epoch + 1): | ||
| node.consensusManager[].actionTracker.knownValidators[idx] = wallSlot |
There was a problem hiding this comment.
we should log a notice / warning here that the validator is exited
There was a problem hiding this comment.
Might not be exited but not yet active, too. The window there is smaller because most of the time it's not active on that side of the timeline, it won't have a validator index yet, but there can be some window after the deposit contract picks it up but before the churn rate limits let it become active.
The check here is deliberately broad. The actual Nimbus mechanism cares about active-or-not, not why it might not be active, which is a bit irrelevant in determining whether it should be asking the action tracker to schedule actions.
There was a problem hiding this comment.
The actual Nimbus mechanism cares about active-or-not,
the user cares about knowing about the state of their validator - ie the logging can differentiate between reasons, once it has figured out it's not active
Fix #4787