fix SSZ response for produceBlindedBlock
#4943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `produceBlindedBlock`, we sent the `ForkedBlindedBeaconBlock` when requested to reply in SSZ format. However, expected result is just the inner `ForkyBlindedBeaconBlock` together with `eth-consensus-version`. Note: We do not use SSZ format in our VC for this endpoint at this time, which explains why we haven't noticed earlier.
etan-status
commented
May 12, 2023
| BlockType: ForkedBeaconBlock|ForkedBlindedBeaconBlock]( | ||
| BlockType: ForkedBeaconBlock]( |
There was a problem hiding this comment.
Verified that this is not needed anymore, by compiling with this overload
proc writeValue*[
BlockType: ForkedBlindedBeaconBlock](
writer: var JsonWriter[RestJson],
value: BlockType) {.raises: [IOError, Defect].} =
static: raiseAssert "error"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
produceBlindedBlock, we sent theForkedBlindedBeaconBlockwhen requested to reply in SSZ format. However, expected result is just the innerForkyBlindedBeaconBlocktogether witheth-consensus-version.Note: We do not use SSZ format in our VC for this endpoint at this time, which explains why we haven't noticed earlier.