Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use v1.4.0-beta.4 consensus spec tests #5561

Closed
wants to merge 1 commit into from
Closed

use v1.4.0-beta.4 consensus spec tests #5561

wants to merge 1 commit into from

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Nov 4, 2023

still contains some unaddressed issues; don't yet merge

@tersec tersec marked this pull request as draft November 4, 2023 09:42
Copy link

github-actions bot commented Nov 4, 2023

Unit Test Results

         9 files  ±  0    1 092 suites  ±0   27m 26s ⏱️ - 5m 37s
  3 942 tests +49    3 620 ✔️ +24  322 💤 +25  0 ±0 
16 045 runs  +69  15 697 ✔️ +44  348 💤 +25  0 ±0 

Results for commit 77831a4. ± Comparison against base commit fb18f09.

Comment on lines +796 to +797
db.blobs.putSZSSZ(blobkey(
value.signed_block_header.message.body_root, value.index), value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these should be by block root, not body root.

Addressed in the other PR:

@tersec
Copy link
Contributor Author

tersec commented Nov 6, 2023

#5565 contains a superset of these ideas in a working PR.

@tersec tersec closed this Nov 6, 2023
@tersec tersec deleted the cxD branch November 6, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants