Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial simple/naive attestation aggregation #629

Merged
merged 6 commits into from
Dec 13, 2019
Merged

initial simple/naive attestation aggregation #629

merged 6 commits into from
Dec 13, 2019

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Dec 6, 2019

#497

This is mostly the aggregation per se.

Remaining elements, intentionally not in this PR:

  • calling this from beacon_node in time for 2/3 through slot durations; this should be fast enough that doing so at 2/3 through suffices;
  • adding/double-checking validations some of which already exist in attestation_pool
  • now that Integrate the native LibP2P implementation #632 has been merged, use it for the various validations on the message level, mostly max gossip message size and matching topics/message types.
  • tests for validation of those messages (dependent on mocking gossipsub messages)

@tersec tersec changed the title [WIP] naive attestation aggregation naive attestation aggregation Dec 10, 2019
@tersec tersec changed the title naive attestation aggregation initial simple/naive attestation aggregation Dec 10, 2019
@tersec
Copy link
Contributor Author

tersec commented Dec 10, 2019

https://ci.status.im/blue/organizations/jenkins/nimbus%2Fnim-beacon-chain%2Fprs/detail/PR-629/6/pipeline/68 failure looks spurious:

+ make -j6 DISABLE_TEST_FIXTURES_SCRIPT=1 test
mkdir: cannot create directory ‘build’: File exists
vendor/nimbus-build-system/makefiles/targets.mk:17: recipe for target 'build' failed
make: *** [build] Error 1
make: *** Waiting for unfinished jobs....
script returned exit code 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant