implement SingleAttestation #6783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Dec 22, 2024
arnetheduck
reviewed
Dec 22, 2024
| warn "No shuffling for attestation - report bug", | ||
| attestation = shortLog(attestation), target = shortLog(target) | ||
| return errIgnore("Attestation: no shuffling") | ||
| beacon_committee = get_beacon_committee( |
There was a problem hiding this comment.
here, ideally we'd have a fast and a slow path - the fast path is for when the shuffling is cached - then we check beacon committee and other "fast" checks and finally sig..
if instead the committee is unknown, we first check the signature and only then do we compute the shuffling to check the other fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for https://notes.ethereum.org/@ethpandaops/pectra-devnet-5