Code

[Ready 1/2] Fork choice rewrite#865

Code

Merged

mratsim merged 22 commits intodevelstatus-im/nimbus-eth2:develfrom gasperstatus-im/nimbus-eth2:gasperCopy head branch name to clipboardApr 9, 2020

+2,871-4

Commits

Commits on Apr 9, 2020

• initial fork-choice refactor

  mratsim

  committed
  088181b

• Add fork_choice test for "no votes"

  mratsim

  committed
  7759055

• Initial test with voting: fix handling of unknown validators and parent blocks

  mratsim

  committed
  b2c7034

• Fix tiebreak of votes

  mratsim

  committed
  cc712b7

• Cleanup debugging traces

  mratsim

  committed
  e9d9c73

• Complexify the vote test

  mratsim

  committed
  6e2e28b

• fakeHash use the bigEndian repr of number + fix tiebreak for good

  mratsim

  committed
  a2e41b9

• Stash changes: found critical bug in nimcrypto == and var openarray

  mratsim

  committed
  8af3440

• Passing fork choice tests with varying votes

  mratsim

  committed
  051b0e9

• Add FFG fork choice scenario + fork choice to the test suite

  mratsim

  committed
  1d0b408

• Not sure why lmdb / rocksdb reappeared in rebase

  mratsim

  committed
  30bcbb1

• Add sanity checks to .nimble file + integrate fork choice tests to the test DB and test timing

  mratsim

  committed
  4947db0

• Cleanup debugging echos

  mratsim

  committed
  17d9ed3

• nimcrypto fix #864 as been merged, remove TODO comment

  mratsim

  committed
  133b6fd

• Turn fork choice exception-free

  mratsim

  committed
  10848b7

• Cleanup "result" to ensure early return is properly used

  mratsim

  committed
  211901a

• Add a comment on private/public error code vs Result

  mratsim

  committed
  d3227b0

• result -> results following #866

  mratsim

  committed
  925ab9f

• Address comments:

  Show description for 22eebc8
  mratsim

  committed
  22eebc8

• re-enable all sanity checks

  mratsim

  committed
  e12b89f

• tag no raise for process_attestation

  mratsim

  committed
  b5355ca

• use raises defect everywhere in fork choice and fix process_attestation test

  mratsim

  committed
  5aba3b5