Skip to content

Commit

Permalink
chore(tests_: remove tests that use public chats
Browse files Browse the repository at this point in the history
  • Loading branch information
jrainville committed Jan 25, 2023
1 parent fdc0dce commit 4a93fa1
Show file tree
Hide file tree
Showing 12 changed files with 3 additions and 298 deletions.
7 changes: 0 additions & 7 deletions test/ui-test/src/screens/StatusMainScreen.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
class MainScreenComponents(Enum):
MAIN_WINDOW = "statusDesktop_mainWindow"
POPUP_OVERLAY = "statusDesktop_mainWindow_overlay"
PUBLIC_CHAT_ICON = "mainWindow_public_chat_icon_StatusIcon"
CHAT_NAVBAR_ICON = "navBarListView_Chat_navbar_StatusNavBarTabButton"
COMMUNITY_PORTAL_BUTTON = "navBarListView_Communities_Portal_navbar_StatusNavBarTabButton"
JOIN_PUBLIC_CHAT = "join_public_chat_StatusMenuItem"
Expand Down Expand Up @@ -99,12 +98,6 @@ def wait_for_banner_to_disappear(self, banner_type: str, timeoutMSec: int = 3000
sleep_test(0.5)
verify_failure(f"Banner is still visible after {timeoutMSec}ms")

def join_chat_room(self, room: str):
click_obj_by_name(MainScreenComponents.PUBLIC_CHAT_ICON.value)
#click_obj_by_name(MainScreenComponents.JOIN_PUBLIC_CHAT.value)
type(ChatNamePopUp.INPUT_ROOM_TOPIC_TEXT.value, room)
click_obj_by_name(ChatNamePopUp.START_CHAT_BTN.value)

def open_chat_section(self):
click_obj_by_name(MainScreenComponents.CHAT_NAVBAR_ICON.value)

Expand Down
3 changes: 0 additions & 3 deletions test/ui-test/testSuites/global_shared/scripts/global_names.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,12 @@
# Main Window - chat related:
mainWindow_statusChatNavBarListView_ListView = {"container": statusDesktop_mainWindow, "objectName": "statusChatNavBarListView", "type": "ListView", "visible": True}
navBarListView_Chat_navbar_StatusNavBarTabButton = {"checkable": True, "container": mainWindow_statusChatNavBarListView_ListView, "objectName": "Messages-navbar", "type": "StatusNavBarTabButton", "visible": True}
mainWindow_public_chat_icon_StatusIcon = {"container": statusDesktop_mainWindow, "objectName": "public-chat-icon", "source": "qrc:/StatusQ/src/assets/img/icons/public-chat.svg", "type": "StatusIcon", "visible": True}
chatList_Repeater = {"container": statusDesktop_mainWindow, "objectName": "chatListItems", "type": "Repeater", "visible": True}
chatList = {"container": statusDesktop_mainWindow, "objectName": "ContactsColumnView_chatList", "type": "StatusChatList"}
mainWindow_startChat = {"checkable": True, "container": statusDesktop_mainWindow, "objectName": "startChatButton", "type": "StatusIconTabButton"}
join_public_chat_StatusMenuItem = {"checkable": False, "container": statusDesktop_mainWindow_overlay, "enabled": True, "text": "Join public chat", "type": "StatusMenuItem", "unnamed": 1, "visible": True}
chatView_messageInput = {"container": statusDesktop_mainWindow, "objectName": "messageInputField", "type": "TextArea", "visible": True}
chatView_StatusChatInfoButton = {"container": statusDesktop_mainWindow, "objectName": "chatInfoBtnInHeader", "type": "StatusChatInfoButton", "visible": True}
chatInfoButton_Pin_Text = {"container": chatView_StatusChatInfoButton, "objectName": "StatusChatInfo_pinText", "type": "StatusBaseText", "visible": True}
joinPublicChat_input = {"container": statusDesktop_mainWindow_overlay, "objectName": "joinPublicChannelInput", "type": "TextEdit", "visible": True}
startChat_Btn = {"container": statusDesktop_mainWindow_overlay, "objectName": "startChatButton", "type": "StatusButton"}
chatButtonsPanelConfirmDeleteMessageButton_StatusButton = {"container": statusDesktop_mainWindow_overlay, "objectName": "chatButtonsPanelConfirmDeleteMessageButton", "type": "StatusButton"}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,6 @@ def signs_up_with_seed_phrase_process_steps(context, seed_phrase: str, user: str
the_user_signs_up(user, password)
the_user_lands_on_the_signed_in_app()

def the_user_joins_chat_room(chat_room: str):
main_screen = StatusMainScreen()
main_screen.join_chat_room(chat_room)
chat_screen = StatusChatScreen()
chat_screen.verify_chat_title(chat_room)

def the_user_opens_the_chat_section():
main_screen = StatusMainScreen()
main_screen.open_chat_section()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,27 +40,3 @@ Feature: Search feature (ctrl+F)
And the user searches for "automation"
When the user clicks on the search result for channel "automation-community"
Then the channel named "automation-community" is open

@mayfail
# myfail because of dekstop issue #7989. Once it is fixed, remove tag.
Scenario: The user can search for a public channel
Given the user opens the search menu
And the user searches for "automation"
When the user clicks on the search result for channel "search-automation-test-2"
Then the chat title is "search-automation-test-2"

@mayfail
# myfail because of desktop issue #7989. Once it is fixed, remove tag.
Scenario: The user can search for a message in a public channel
Given the user opens the chat section
And the user joins chat room "search-automation-test-1"
And the user sends a random chat message
# Go back to the portal so that we see if the search really redirects
And the user opens the community portal section
And the user opens the search menu

When the user searches the random message
Then the search menu shows 1 results

When the user clicks on the search result for the random message
Then the chat title is "search-automation-test-1"
2 changes: 1 addition & 1 deletion test/ui-test/testSuites/suite_messaging/suite.conf
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ AUT=nim_status_client
ENVVARS=envvars
LANGUAGE=Python
OBJECTMAPSTYLE=script
TEST_CASES=tst_ChatFlow tst_groupChat tst_adminGroupChat tst_chatsNavigation
TEST_CASES=tst_groupChat tst_adminGroupChat
VERSION=3
WRAPPERS=Qt
31 changes: 0 additions & 31 deletions test/ui-test/testSuites/suite_messaging/tst_ChatFlow/bdd_hooks.py

This file was deleted.

140 changes: 0 additions & 140 deletions test/ui-test/testSuites/suite_messaging/tst_ChatFlow/test.feature

This file was deleted.

8 changes: 0 additions & 8 deletions test/ui-test/testSuites/suite_messaging/tst_ChatFlow/test.py

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ Feature: Status Desktop Contacts Flows
Then the contact request for chat key "zQ3shQihZMmciZWUrjvsY6kUoaqSKp9DFSjMPRkkKGty3XCKZ" is present in the pending requests tab
# TODO for future improvements: log into the other account and check that we received the request (will require some cleanup)

@relyon-mailserver
@relyon-mailserver @mayfail
# FIXME this test will fail because we no longer support public channels. Re-implement in a community channel. Issue #9252
Scenario: The user can add a contact from the chat
# User 1 sends a message in the channel
When the user opens the chat section
Expand Down

0 comments on commit 4a93fa1

Please sign in to comment.