fix(statusApp): resolving qml errors/warnings pt2.1

Relates to #8864
status-im · Feb 22, 2023 · d00b542 · d00b542
1 parent eacf039
commit d00b542
Show file tree

Hide file tree

Showing 8 changed files with 507 additions and 500 deletions.
diff --git a/ui/StatusQ/src/StatusQ/Core/StatusScrollView.qml b/ui/StatusQ/src/StatusQ/Core/StatusScrollView.qml
@@ -49,8 +49,6 @@ Flickable {
     rightMargin: rightPadding
     contentWidth: contentItem.childrenRect.width
     contentHeight: contentItem.childrenRect.height
-    implicitWidth: contentWidth + leftPadding + rightPadding
-    implicitHeight: contentHeight + topPadding + bottomPadding
     boundsBehavior: Flickable.StopAtBounds
     maximumFlickVelocity: 2000
     synchronousDrag: true

diff --git a/ui/app/AppLayouts/Chat/controls/community/CommunityLogoPicker.qml b/ui/app/AppLayouts/Chat/controls/community/CommunityLogoPicker.qml
@@ -28,9 +28,7 @@ Item {
     ColumnLayout {
         id: layout
 
-        implicitWidth: childrenRect.width
-        implicitHeight: childrenRect.height
-
+        anchors.horizontalCenter: parent.horizontalCenter
         spacing: 8
 
         StatusBaseText {

diff --git a/ui/app/AppLayouts/Chat/panels/communities/CommunityEditSettingsPanel.qml b/ui/app/AppLayouts/Chat/panels/communities/CommunityEditSettingsPanel.qml
@@ -26,7 +26,7 @@ StatusScrollView {
     objectName: "communityEditPanelScrollView"
 
     implicitWidth: contentWidth
-    implicitHeight: layout.childrenRect.height
+    contentHeight: layout.implicitHeight
 
     property alias name: nameInput.text
     property alias description: descriptionTextInput.text
@@ -54,7 +54,6 @@ StatusScrollView {
         id: layout
 
         width: 608
-        height: parent.height
 
         spacing: 12
 
@@ -93,9 +92,11 @@ StatusScrollView {
                 id: pickColorComponent
 
                 StatusStackModal {
-                    anchors.centerIn: parent
                     width: 640
+                    height: root.height
+                    anchors.centerIn: parent
                     replaceItem: CommunityColorPanel {
+                        clip: true
                         Component.onCompleted: color = colorPicker.color
                         onAccepted: {
                             colorPicker.color = color;

diff --git a/ui/app/AppLayouts/Chat/panels/communities/CommunityOverviewSettingsPanel.qml b/ui/app/AppLayouts/Chat/panels/communities/CommunityOverviewSettingsPanel.qml
@@ -174,6 +174,7 @@ StackLayout {
 
         content: CommunityEditSettingsPanel {
             name: root.name
+            implicitWidth: parent.width
             description: root.description
             introMessage: root.introMessage
             outroMessage: root.outroMessage
@@ -182,6 +183,7 @@ StackLayout {
             color: root.color
             logoImageData: root.logoImageData
             bannerImageData: root.bannerImageData
+            height: root.height
             options {
                 archiveSupportEnabled: root.archiveSupportEnabled
                 requestToJoinEnabled: root.requestToJoinEnabled

diff --git a/ui/app/AppLayouts/CommunitiesPortal/panels/CommunityColorPanel.qml b/ui/app/AppLayouts/CommunitiesPortal/panels/CommunityColorPanel.qml
@@ -12,6 +12,8 @@ import StatusQ.Popups 0.1
 StatusScrollView {
     id: root
 
+    contentWidth: column.implicitWidth
+    contentHeight: column.implicitHeight
     property string title: qsTr("Community Colour")
 
     property var rightButtons: StatusButton {

diff --git a/ui/app/AppLayouts/CommunitiesPortal/popups/CreateCommunityPopup.qml b/ui/app/AppLayouts/CommunitiesPortal/popups/CreateCommunityPopup.qml
@@ -368,14 +368,17 @@ StatusStackModal {
     stackItems: [
         StatusScrollView {
             id: generalView
-
+            implicitWidth: root.width
+            implicitHeight: root.height
+            contentWidth: availableWidth
+            contentHeight: generalViewLayout.implicitHeight
             readonly property bool canGoNext: nameInput.valid && descriptionTextInput.valid
 
             clip: false
 
             ColumnLayout {
                 id: generalViewLayout
-                width: generalView.availableWidth
+                width: generalView.contentWidth
                 spacing: 16
 
                 CommunityNameInput {