Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Community: can't use @everyone in community channel #10212

Closed
anastasiyaig opened this issue Apr 6, 2023 · 0 comments · Fixed by #10245
Closed

Community: can't use @everyone in community channel #10212

anastasiyaig opened this issue Apr 6, 2023 · 0 comments · Fixed by #10245
Assignees
@jrainville
Labels
bug Something isn't working
Milestone
0.12

Comments

@anastasiyaig
Copy link
Contributor

Description

  1. join community
  2. in any channel type @everyone
Screen.Recording.2023-04-06.at.12.33.42.mov
@anastasiyaig anastasiyaig added bug Something isn't working E:Bugfixes labels Apr 6, 2023
@anastasiyaig anastasiyaig added this to the 0.12.0 milestone Apr 6, 2023
@jrainville jrainville self-assigned this Apr 7, 2023
jrainville added a commit that referenced this issue Apr 7, 2023
@jrainville
fix(mentions): fix @everyone inserting incorrectly sometimes
b9a5c7f 
Fixes #10212

The problem was that we were detecting that the name was empty string and comparing to another empty string and inserting that, which is incorrect.

There was also a problem with the detection of the name being completely written. onKeyPressed didn't take into account the new letter added, onKeyReleased does.
@jrainville jrainville mentioned this issue Apr 7, 2023
Merged
jrainville added a commit that referenced this issue Apr 11, 2023
@jrainville
fix(mentions): fix @everyone inserting incorrectly sometimes
fe64d0e 
Fixes #10212

The problem was that we were detecting that the name was empty string and comparing to another empty string and inserting that, which is incorrect.

There was also a problem with the detection of the name being completely written. onKeyPressed didn't take into account the new letter added, onKeyReleased does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
bug Something isn't working
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
0.12
Development

Successfully merging a pull request may close this issue.

fix(mentions): fix @everyone inserting incorrectly sometimes status-im/status-desktop
2 participants
@jrainville @anastasiyaig