Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser plugin - transaction via Uniswap doesn't go through #16063

Closed
Tracked by #14794 ...
virginiabalducci opened this issue Aug 9, 2024 · 6 comments · Fixed by #16365
Closed
Tracked by #14794 ...

Browser plugin - transaction via Uniswap doesn't go through #16063

virginiabalducci opened this issue Aug 9, 2024 · 6 comments · Fixed by #16365
Assignees
Labels
bug Something isn't working dapp-interactions E:D Browser Plugin Connector M1 Task to implement the connector between the browser plugin and Status wallet-team
Milestone

Comments

@virginiabalducci
Copy link

virginiabalducci commented Aug 9, 2024

Bug Report

Description

When connected to Uniswap via Browser plug in, transaction gets stuck

Steps to reproduce

  1. Have the Status browser extension installed
  2. Open the desktop app and use an account that has some funds
  3. Go to Uniswap and connect the wallet to Status browser
  4. On Uniswap, make a swap for example 1 usdt to 1 usdc
  5. On the Status desktop app, Sign the transaction.

Expected behavior

Sign transaction details to show correct data
Sign transaction to go through correctly

Actual behavior

Sign transaction details are ilegible
Screenshot 2024-08-09 at 11 00 34 AM
Transaction on Uniswap's end remains Pending
Status app shows a successful toast but nothing else happens
I re-tried the transaction and the Status Sign modal showed up 1 or 2 times but nothing happens on Uniswap's end.

https://github.com/user-attachments/assets/85e096ab-079d-4a78-bad3-b49e04652a8a
https://github.com/user-attachments/assets/3bae0ed9-44ec-48ab-8d0f-b5cd8fc42533
Screenshot 2024-08-09 at 10 26 35 AM
Screenshot 2024-08-09 at 10 25 52 AM
Screenshot 2024-08-09 at 10 18 50 AM

Additional Information

app.uniswap.org-1723211704025.log

  • Status desktop version: 2.30 rc-5
  • Operating System: Mac OS Sonoma, Chrome Version 127.0.6533.89 (Official Build) (arm64)
@virginiabalducci virginiabalducci added bug Something isn't working E:D Browser Plugin Connector M1 Task to implement the connector between the browser plugin and Status labels Aug 9, 2024
@virginiabalducci virginiabalducci added this to the 2.30.0 Beta milestone Aug 9, 2024
@virginiabalducci
Copy link
Author

Tagging @status-im/web for visibility

@felicio
Copy link

felicio commented Aug 9, 2024

@MishkaRogachev could you please check?

@MishkaRogachev MishkaRogachev self-assigned this Aug 11, 2024
@MishkaRogachev
Copy link
Contributor

Screenshot 2024-08-12 at 11 16 58 Confirmed

@MishkaRogachev
Copy link
Contributor

MishkaRogachev commented Aug 12, 2024

Сurrently managed to establish that the transaction runs normally, but after calling eth_sendTransaction, uniswap makes several forwarded calls, which most likely have unexpected output.

-----------------------------------> Transaction hash:  0x16dd81eddd55462a25c3486d0469bc357480b659e076fce71283edafad70d356
-----------------------------------> CallRPC:  { 0 eth_chainId [] https://app.uniswap.org app.uniswap.org https://app.uniswap.org/favicon.png}
-----------------------------------> CallRPC:  { 0 eth_getTransactionByHash [0x16dd81eddd55462a25c3486d0469bc357480b659e076fce71283edafad70d356] https://app.uniswap.org app.uniswap.org https://app.uniswap.org/favicon.png}
-----------------------------------> forwardRPC ok:  <nil>
-----------------------------------> CallRPC:  { 0 eth_blockNumber [] https://app.uniswap.org app.uniswap.org https://app.uniswap.org/favicon.png}
-----------------------------------> CallRPC:  { 0 eth_chainId [] https://app.uniswap.org app.uniswap.org https://app.uniswap.org/favicon.png}
-----------------------------------> CallRPC:  { 0 eth_chainId [] https://app.uniswap.org app.uniswap.org https://app.uniswap.org/favicon.png}
-----------------------------------> CallRPC:  { 0 eth_getTransactionByHash [0x16dd81eddd55462a25c3486d0469bc357480b659e076fce71283edafad70d356] https://app.uniswap.org app.uniswap.org https://app.uniswap.org/favicon.png}

UPD: It seems to me, GETH can't find a transaction with such hash:

-----------------------------------> Transaction hash:  0x16dd81eddd55462a25c3486d0469bc357480b659e076fce71283edafad70d356
...
-----------------------------------> CallRPC:  { 0 eth_getTransactionByHash [0x16dd81eddd55462a25c3486d0469bc357480b659e076fce71283edafad70d356] https://app.uniswap.org app.uniswap.org https://app.uniswap.org/favicon.png}
-----------------------------------> RAW RESPONSE:  {"jsonrpc":"2.0","id":0,"result":null}
-----------------------------------> forwardRPC ok:  <nil>
-----------------------------------> CallRPC:  { 0 eth_getTransactionByHash [0x16dd81eddd55462a25c3486d0469bc357480b659e076fce71283edafad70d356] https://app.uniswap.org app.uniswap.org https://app.uniswap.org/favicon.png}
-----------------------------------> RAW RESPONSE:  {"jsonrpc":"2.0","id":0,"result":null}
-----------------------------------> forwardRPC ok:  <nil>

Etherscan can't find the transaction either: https://optimistic.etherscan.io/tx/0x16dd81eddd55462a25c3486d0469bc357480b659e076fce71283edafad70d356

@anastasiyaig
Copy link
Contributor

I tested transactioning with Uniswap in 2.30 r7 today and i cant sign message to uniswap
unsiwap reject

uniswap.reject.mp4

also, disconnecting from Uniswap in dapp browser does not disconnect it from Status, still shows as connected

@virginiabalducci
Copy link
Author

Issue still reproducible on BC and WC #16303

@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dapp-interactions E:D Browser Plugin Connector M1 Task to implement the connector between the browser plugin and Status wallet-team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants