Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send multiple images (album) in one message #6374

Closed
7 tasks
MishkaRogachev opened this issue Jul 6, 2022 · 5 comments · Fixed by #9744
Closed
7 tasks

Send multiple images (album) in one message #6374

MishkaRogachev opened this issue Jul 6, 2022 · 5 comments · Fixed by #9744
Assignees
Labels
Milestone

Comments

@MishkaRogachev
Copy link
Contributor

MishkaRogachev commented Jul 6, 2022

image

Description

Sending several images should be implemented with one message

Acceptance Criteria

  • Sent message with several images shown in chat view with horizontal layouted images
  • UI selection shows that is one whole message

This is coming from mobile implementation:

Also if album is sent, then you should be able to do the following actions:

  • - Editing this message with album (changing text, pictures)
  • - Leave reaction to a message with album
  • - Delete message with album
  • - Copy text if text exist in the message
  • - Reply

All of those actions are able to be done for album, but not for separate image inside this album

@anastasiyaig
Copy link
Contributor

@benjthayer @John-44 i guess we need designs for it ? Since it is implemented on mobile side now (and we have APIs)

@anastasiyaig anastasiyaig moved this to Iteration Backlog in Status Desktop/Mobile Board Mar 6, 2023
@benjthayer
Copy link

Thanks @anastasiyaig

@John-44 I think we may be looking at this at the same time. The only reference I can find of sending multiple images is this:
https://www.figma.com/file/Mr3rqxxgKJ2zMQ06UAKiWL/%F0%9F%92%AC-Chat%E2%8E%9CDesktop?node-id=11387%3A393376&t=RtuAs24fbw2fhmuk-4

We could do with exploring either wrapping the images if needed (i.e. if the composite width of the images sent are wider than the availably body width of the chat) or implementing something like in mobile where they are sent individually then gridded

@benjthayer
Copy link

The new destkop designs for reference - @John-44 I could take a look at the current desktop designs and align them functionally with what Filipe has for the new desktop designs?
https://www.figma.com/file/qSIh8wh9EVdY8S2sZce15n/Composer-for-Desktop?node-id=7150%3A392522&t=oE2Z1Xd0UGswbsOC-4

@John-44
Copy link

John-44 commented Mar 6, 2023

@benjthayer @John-44 i guess we need designs for it ? Since it is implemented on mobile side now (and we have APIs)

@anastasiyaig we already have designs for this, see the figma I linked to in this comment #9744 (comment)

@John-44
Copy link

John-44 commented Mar 6, 2023

@anastasiyaig anastasiyaig changed the title Send several images via one message Send multiple images (album) in one message Mar 7, 2023
@jrainville jrainville added this to the 0.11.0 milestone Mar 9, 2023
@jrainville jrainville moved this from Iteration Backlog to In Progress in Status Desktop/Mobile Board Mar 9, 2023
borismelnik added a commit that referenced this issue Mar 14, 2023
@borismelnik borismelnik moved this from In Progress to Code review in Status Desktop/Mobile Board Mar 14, 2023
borismelnik added a commit that referenced this issue Mar 15, 2023
@borismelnik borismelnik moved this from Code review to QA in Status Desktop/Mobile Board Mar 16, 2023
borismelnik added a commit that referenced this issue Mar 16, 2023
@anastasiyaig anastasiyaig linked a pull request Mar 17, 2023 that will close this issue
4 tasks
borismelnik added a commit that referenced this issue Mar 20, 2023
borismelnik added a commit that referenced this issue Mar 20, 2023
borismelnik added a commit that referenced this issue Mar 21, 2023
borismelnik added a commit that referenced this issue Mar 22, 2023
borismelnik added a commit that referenced this issue Mar 22, 2023
borismelnik added a commit that referenced this issue Mar 23, 2023
borismelnik added a commit that referenced this issue Mar 23, 2023
borismelnik added a commit that referenced this issue Mar 24, 2023
borismelnik added a commit that referenced this issue Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants