Status Chat Input: Empty mention if name property is missing, but alias, nickname or ensName is present #8691
Assignees
Labels
bug
Something isn't working
Comments
caybro
added a commit
that referenced
this issue
Jan 6, 2023
- follow the order of properties that `ProfileUtils.displayName()` uses elsewhere in the application - prefer nickname or ensName over displayName if the user has them Fixes: #8691
1 task
1 task
caybro
added a commit
that referenced
this issue
Jan 7, 2023
- follow the order of properties that `ProfileUtils.displayName()` uses elsewhere in the application - prefer nickname or ensName over displayName if the user has them Fixes: #8691
caybro
added a commit
that referenced
this issue
Jan 9, 2023
- follow the order of properties that `ProfileUtils.displayName()` uses elsewhere in the application - prefer nickname or ensName over displayName if the user has them Fixes: #8691
github-project-automation
bot
moved this from Code review
to Done
in Status Desktop/Mobile Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue created based on findings when StatusChatInput was added to storybook.
When the contact does not have name, but has any of the following: "name", "nickname", "ensName", "alias", mentioning him will result in empty mention. The mention suggestions work as expected. The suggestions have logic on this and the name will be the first model item not empty in ["name", "nickname", "ensName", "alias"].
Please see the below quote:
Just a small suggestion added and.. Not sure about the scope of this task but testing it I've seen this issue with
maria.ethuser mention:Screen.Recording.2022-12-07.at.11.34.19.mov
Originally posted by @noeliaSD in #8653 (review)
The text was updated successfully, but these errors were encountered: