Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel logo is shown in the middle of the chat #8955

Closed
osmaczko opened this issue Jan 4, 2023 · 0 comments · Fixed by #9001
Closed

Channel logo is shown in the middle of the chat #8955

osmaczko opened this issue Jan 4, 2023 · 0 comments · Fixed by #9001
Assignees
@osmaczko
Labels
bug Something isn't working
Milestone
0.9.0 RC

Comments

@osmaczko
Copy link
Contributor

osmaczko commented Jan 4, 2023

Bug Report

Description

image

Channel logo in the middle, new messages in the upper half, old messages at the bottom.

Steps to reproduce

  • click the "gap" component that is positioned in the middle

Additional Information

  • Status desktop version: master (5f55cd2)

Notes

Most likely messages ordering is ignored when filling the gap
@osmaczko osmaczko added bug Something isn't working Chat labels Jan 4, 2023
@iurimatias iurimatias added this to the 0.9.0 RC milestone Jan 5, 2023
@jrainville jrainville assigned jrainville and osmaczko and unassigned jrainville Jan 5, 2023
osmaczko added a commit that referenced this issue Jan 9, 2023
@osmaczko
fix(chat/messages): set clock value for new messages marker
4b1a846 
New messages marker had a clock value of "0" before. Since all
messages are inserted based on the clock value, new messages marker
would cause other "0"-valued clock items to be inserted after it,
effectively making chat header being displayed in the middle of the
chat.

Setting new messages marker clock value to the clock of the message it
points to solves the issue.

fixes: #8955
osmaczko added a commit that referenced this issue Jan 9, 2023
@osmaczko
fix(chat/messages): set clock value for new messages marker
81a5653 
New messages marker had a clock value of "0" before. Since all
messages are inserted based on the clock value, new messages marker
would cause other "0"-valued clock items to be inserted after it,
effectively making chat header being displayed in the middle of the
chat.

Setting new messages marker clock value to the clock of the message it
points to solves the issue.

fixes: #8955
@osmaczko osmaczko mentioned this issue Jan 9, 2023
Merged
osmaczko added a commit that referenced this issue Jan 9, 2023
@osmaczko
fix(chat/messages): set clock value for new messages marker
ac87254 
New messages marker had a clock value of "0" before. Since all
messages are inserted based on the clock value, new messages marker
would cause other "0"-valued clock items to be inserted after it,
effectively making chat header being displayed in the middle of the
chat.

Setting new messages marker clock value to the clock of the message it
points to solves the issue.

fixes: #8955
osmaczko added a commit that referenced this issue Jan 11, 2023
@osmaczko
fix(chat/messages): set clock value for new messages marker
fe4e14f 
New messages marker had a clock value of "0" before. Since all
messages are inserted based on the clock value, new messages marker
would cause other "0"-valued clock items to be inserted after it,
effectively making chat header being displayed in the middle of the
chat.

Setting new messages marker clock value to the clock of the message it
points to solves the issue.

fixes: #8955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osmaczko osmaczko

Labels
bug Something isn't working
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
0.9.0 RC
Development

Successfully merging a pull request may close this issue.

Fix/8955/chat logo in the middle status-im/status-desktop
3 participants
@iurimatias @jrainville @osmaczko