Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0 missed message marker when last message was deleted #9014

Closed
jrainville opened this issue Jan 9, 2023 · 0 comments · Fixed by #9062
Closed

0 missed message marker when last message was deleted #9014

jrainville opened this issue Jan 9, 2023 · 0 comments · Fixed by #9062
Assignees
@borismelnik
Labels
bug Something isn't working
Milestone
0.9.0 RC

Comments

@jrainville
Copy link
Member

Bug Report

Description

image

Steps to reproduce

  1. Have chat A be common to Account 1 and 2. Account 1 doesn't have chat A active
  2. In chat A, have Account 2 write something
  3. Account 2 goes to chat A, sees the message and the marker
  4. Account 2 deletes the message
  5. Marker for Account 1 gets updated to "0 missed message(s)"

Expected behavior

When the latest message is deleted and the marker would show 0 missed messages, just delete the marker instead.

Actual behavior

Shows 0 missed messages

Additional Information
@jrainville jrainville added the bug Something isn't working label Jan 9, 2023
@jrainville jrainville added this to the 0.9.0 RC milestone Jan 9, 2023
@jrainville jrainville moved this to Iteration Backlog in Status Desktop/Mobile Board Jan 9, 2023
@borismelnik borismelnik moved this from Iteration Backlog to In Progress in Status Desktop/Mobile Board Jan 11, 2023
borismelnik added a commit that referenced this issue Jan 11, 2023
@borismelnik
fix(chat): Update new messages marker when message was removed
8e40945 
Fixes: #9014
@borismelnik borismelnik mentioned this issue Jan 11, 2023
Merged
@borismelnik borismelnik moved this from In Progress to Code review in Status Desktop/Mobile Board Jan 11, 2023
borismelnik added a commit that referenced this issue Jan 12, 2023
@borismelnik
fix(chat): Update new messages marker when message was removed
52b2956 
Fixes: #9014
@borismelnik borismelnik moved this from Code review to Can't Reproduce in Status Desktop/Mobile Board Jan 12, 2023
@borismelnik borismelnik moved this from Can't Reproduce to Code review in Status Desktop/Mobile Board Jan 12, 2023
jrainville pushed a commit that referenced this issue Jan 12, 2023
@borismelnik @jrainville
fix(chat): Update new messages marker when message was removed
c2f84fd 
Fixes: #9014
@github-project-automation github-project-automation bot moved this from Code review to Done in Status Desktop/Mobile Board Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@borismelnik borismelnik

Labels
bug Something isn't working
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
0.9.0 RC
Development

Successfully merging a pull request may close this issue.

fix(chat): Update new messages marker when message was removed status-im/status-desktop
2 participants
@jrainville @borismelnik