Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Contact request button and popup in the Contacts Column #9072

Closed
jrainville opened this issue Jan 11, 2023 · 0 comments · Fixed by #9092
Closed

Remove Contact request button and popup in the Contacts Column #9072

jrainville opened this issue Jan 11, 2023 · 0 comments · Fixed by #9092
Assignees
@jrainville
Labels
chore
Milestone
0.10.0

Comments

@jrainville
Copy link
Member

Description

The Contact requests button and popup in the Contacts column of the personal chat is legacy and no longer useful.

The desired flow is using the AC or the Contacts settings, as you can see the actual message the person sent.

This button:
image

This popup:
image

They go bye bye ✂️
@jrainville jrainville added this to the 0.10.0 milestone Jan 11, 2023
@jrainville jrainville self-assigned this Jan 12, 2023
@jrainville jrainville moved this to Iteration Backlog in Status Desktop/Mobile Board Jan 12, 2023
@jrainville jrainville moved this from Iteration Backlog to In Progress in Status Desktop/Mobile Board Jan 12, 2023
jrainville added a commit that referenced this issue Jan 12, 2023
@jrainville
chore(contact-request): remove old contact request button and popup
e44a425 
Fixes #9072

I made clicking on the OS notification open the AC instead of the old popup
@jrainville jrainville mentioned this issue Jan 12, 2023
Merged
@jrainville jrainville moved this from In Progress to Code review in Status Desktop/Mobile Board Jan 12, 2023
jrainville added a commit that referenced this issue Jan 13, 2023
@jrainville
chore(contact-request): remove old contact request button and popup
d1b8caa 
Fixes #9072

I made clicking on the OS notification open the AC instead of the old popup
jrainville added a commit that referenced this issue Jan 13, 2023
@jrainville
chore(contact-request): remove old contact request button and popup
f8c4682 
Fixes #9072

I made clicking on the OS notification open the AC instead of the old popup
@github-project-automation github-project-automation bot moved this from Code review to Done in Status Desktop/Mobile Board Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
chore
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

chore(contact-request): remove old contact request button and popup status-im/status-desktop
1 participant
@jrainville