Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keycard may be factory reseted during unlock flow in some scenarios #9183

Closed
saledjenic opened this issue Jan 18, 2023 · 0 comments · Fixed by #9206
Closed

Keycard may be factory reseted during unlock flow in some scenarios #9183

saledjenic opened this issue Jan 18, 2023 · 0 comments · Fixed by #9206
Assignees
@saledjenic
Labels
bug Something isn't working

Comments

@saledjenic
Copy link
Contributor

As stated in the description of #9149 I figured out that in some cases if user goes back or close the flow (shared module) or close the app (onboarding module or shared module) while he is in unlock flow he may end up with empty keycard.

That may happen if user enters a seed phrase and close the flow before he enters a pin for unlocked keycard.

Both onboarding and shared module should be affected.
@saledjenic saledjenic added bug Something isn't working onboarding labels Jan 18, 2023
@saledjenic saledjenic self-assigned this Jan 18, 2023
@saledjenic saledjenic mentioned this issue Jan 18, 2023
Merged
@saledjenic saledjenic moved this to In Progress in Status Desktop/Mobile Board Jan 19, 2023
saledjenic added a commit that referenced this issue Jan 23, 2023
@saledjenic
fix(@desktop/keycard): keycard may be factory reseted during unlock f…
27a0ad0 
…low in some scenarios (onboarding part)

- Unexpected wiping out the data during the unlock flow handled (onboarding part)
- Back button actions fixed part 2/2 (onboarding part)

Fixes: #9183
saledjenic added a commit that referenced this issue Jan 23, 2023
@saledjenic
fix(@desktop/keycard): keycard may be factory reseted during unlock f…
6c7ebe8 
…low in some scenarios (onboarding part)

- Unexpected wiping out the data during the unlock flow handled (onboarding part)
- Back button actions fixed part 2/2 (onboarding part)

Fixes: #9183
saledjenic added a commit that referenced this issue Jan 23, 2023
@saledjenic
fix(@desktop/keycard): keycard may be factory reseted during unlock f…
239ac1e 
…low in some scenarios (shared module part)

- Unexpected wiping out the data during the unlock flow handled (shared module part)

Fixes: #9183
saledjenic added a commit that referenced this issue Jan 23, 2023
@saledjenic
fix(@desktop/keycard): keycard may be factory reseted during unlock f…
63ec9db 
…low in some scenarios (onboarding part)

- Unexpected wiping out the data during the unlock flow handled (onboarding part)
- Back button actions fixed part 2/2 (onboarding part)

Fixes: #9183
saledjenic added a commit that referenced this issue Jan 23, 2023
@saledjenic
fix(@desktop/keycard): keycard may be factory reseted during unlock f…
74f9d31 
…low in some scenarios (shared module part)

- Unexpected wiping out the data during the unlock flow handled (shared module part)

Fixes: #9183
@saledjenic saledjenic moved this from In Progress to QA in Status Desktop/Mobile Board Jan 23, 2023
@saledjenic saledjenic mentioned this issue Jan 23, 2023
Merged
saledjenic added a commit that referenced this issue Jan 26, 2023
@saledjenic
fix(@desktop/keycard): keycard may be factory reseted during unlock f…
b44fc7a 
…low in some scenarios (onboarding part)

- Unexpected wiping out the data during the unlock flow handled (onboarding part)
- Back button actions fixed part 2/2 (onboarding part)

Fixes: #9183
saledjenic added a commit that referenced this issue Jan 26, 2023
@saledjenic
fix(@desktop/keycard): keycard may be factory reseted during unlock f…
5259747 
…low in some scenarios (shared module part)

- Unexpected wiping out the data during the unlock flow handled (shared module part)

Fixes: #9183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saledjenic saledjenic

Labels
bug Something isn't working
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
No milestone
1 participant
@saledjenic