-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CommunityPermissions): Switch to enable/disable 'Who holds' section #10166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
✔️ status-desktop/branches/linux/PR-10166#1 🔹 ~13 min 🔹 a70a003 🔹 📦 linux package |
caybro
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alexjba
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
micieslak
force-pushed
the
feat/issue-8498
branch
from
April 5, 2023 09:00
a70a003
to
d7421dd
Compare
micieslak
added a commit
that referenced
this pull request
Apr 5, 2023
…nd permission updating It's integral part of #10166 but not pushed togheter by mistake.
micieslak
added a commit
that referenced
this pull request
Apr 5, 2023
…nd permission updating It's integral part of #10166 but not pushed together by mistake.
micieslak
added a commit
that referenced
this pull request
Apr 5, 2023
…nd permission updating It's integral part of #10166 but not pushed together by mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Closes: #8498
Affected areas
Community Permissions components
Note: full integration with the app will be done when per-channel permissions are implemented.
Screenshot of functionality (including design for comparison)
Screencast.2023-04-04.16.45.21.mp4