Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CommunityPermissions): Switch to enable/disable 'Who holds' section #10166

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

micieslak
Copy link
Member

@micieslak micieslak commented Apr 4, 2023

What does the PR do

  • adds visual representation of disabled StatusGroupBox's label
  • adds switch to "Who holds" selector
  • integrates the switch with duplicates detection
  • updates dirty state checks
  • allows defining permissions without holdings specified

Closes: #8498

Affected areas

Community Permissions components

Note: full integration with the app will be done when per-channel permissions are implemented.

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it
Screencast.2023-04-04.16.45.21.mp4

@status-im-auto
Copy link
Member

status-im-auto commented Apr 4, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a70a003 #1 2023-04-04 14:54:41 ~6 min tests-nim 📄log
✔️ a70a003 #1 2023-04-04 14:54:56 ~6 min imports 📄log
✔️ a70a003 #1 2023-04-04 14:57:56 ~9 min macos 🍎dmg
✔️ a70a003 #1 2023-04-04 15:04:57 ~16 min linux-e2e 📄log
✔️ a70a003 #1 2023-04-04 15:16:45 ~28 min windows 💿exe
✔️ d7421dd #2 2023-04-05 09:06:49 ~6 min tests-nim 📄log
✔️ d7421dd #2 2023-04-05 09:07:23 ~6 min imports 📄log
✔️ d7421dd #2 2023-04-05 09:09:30 ~8 min macos 🍎dmg
✔️ d7421dd #2 2023-04-05 09:12:48 ~12 min linux 📦tgz
✔️ d7421dd #2 2023-04-05 09:14:54 ~14 min linux-e2e 📄log
✔️ d7421dd #2 2023-04-05 09:26:18 ~25 min windows 💿exe

@status-im-auto
Copy link
Member

✔️ status-desktop/branches/linux/PR-10166#1 🔹 ~13 min 🔹 a70a003 🔹 📦 linux package

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@micieslak micieslak merged commit 8dafdfc into master Apr 5, 2023
@micieslak micieslak deleted the feat/issue-8498 branch April 5, 2023 09:46
micieslak added a commit that referenced this pull request Apr 5, 2023
…nd permission updating

It's integral part of
#10166 but not pushed
togheter by mistake.
micieslak added a commit that referenced this pull request Apr 5, 2023
…nd permission updating

It's integral part of
#10166 but not pushed
together by mistake.
micieslak added a commit that referenced this pull request Apr 5, 2023
…nd permission updating

It's integral part of
#10166 but not pushed
together by mistake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Community Permissions] Add new switch to enable / disable Who holds option
4 participants