Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SendContactRequestModal): Contact info request and loading UI #10177

Merged
merged 1 commit into from
Apr 6, 2023
Merged

fix(SendContactRequestModal): Contact info request and loading UI #10177

merged 1 commit into from
Apr 6, 2023

Conversation

igor-sirotin
Copy link
Contributor

@igor-sirotin igor-sirotin commented Apr 4, 2023 •
edited
Loading

@igor-sirotin igor-sirotin mentioned this pull request Apr 4, 2023
Merged
@status-im-auto
Copy link
Member

status-im-auto commented Apr 4, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 24c5b28 #1 2023-04-04 20:25:32 ~5 min tests-nim 📄log
✔️ 24c5b28 #1 2023-04-04 20:26:11 ~6 min imports 📄log
✔️ 24c5b28 #1 2023-04-04 20:28:51 ~8 min macos 🍎dmg
✔️ 24c5b28 #1 2023-04-04 20:31:28 ~11 min linux 📦tgz
✔️ 24c5b28 #1 2023-04-04 20:35:19 ~15 min linux-e2e 📄log
✔️ 24c5b28 #1 2023-04-04 20:50:23 ~30 min windows 💿exe
✔️ 752cbee #2 2023-04-05 20:36:40 ~6 min tests-nim 📄log
✔️ 752cbee #2 2023-04-05 20:36:40 ~6 min imports 📄log
✔️ 752cbee #2 2023-04-05 20:39:19 ~9 min macos 🍎dmg
✔️ 752cbee #2 2023-04-05 20:46:03 ~15 min linux-e2e 📄log
✔️ 752cbee #3 2023-04-05 22:03:39 ~41 min windows 💿exe
✔️ 752cbee #5 2023-04-06 07:01:32 ~10 min linux 📦tgz

jrainville
jrainville approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

caybro
caybro approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igor-sirotin igor-sirotin merged commit 7ebfcd0 into master Apr 6, 2023
@igor-sirotin igor-sirotin deleted the fix/issue-8924 branch April 6, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrainville jrainville jrainville approved these changes

@caybro caybro caybro approved these changes

@alexandraB99 alexandraB99 Awaiting requested review from alexandraB99

@imagiMary imagiMary Awaiting requested review from imagiMary

Assignees
No one assigned
Labels
waiting-for-status-go-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contact request view doesn't show account's meta information
4 participants
@igor-sirotin @status-im-auto @caybro @jrainville