chore: bump status-go with filter improvements #15061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (20)
|
12 tasks
|
Closing this PR as it is only meant as dogfooding for filter which is complete (using only fleet nodes) and linked status-go PR status-im/status-go#4665 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Improved lightClient functionality especially fixing issues around Waku-Filter protocol usage and optimizing how filter subscriptions are managed and Filter ping occurs with service node.
Still some optimizations and additional work is pending wrt light client reliability, but this PR brings Filter to a hopefully decent stage(without any major issues) before proceeding with further changes.
Note that if you are subscribed to status community, there would be a lot of filter subscriptions. This still needs optimization which is pending. Anyways, number of subscriptions would help test nwaku node as well to handle soo may :)
Note that to reduce issues with lightClient(by not connecting to other desktop instances), this build only uses fleet nodes and does not do any discovery via peerExchange.
Relevant status-go PR status-im/status-go#4665
Affected areas
LightMode functionality
How to test
Note to enable debug logs while testing.
geth.loggeth.log:In case of any issue please report along with debug logs via DM or as a comment in this PR itself.